chore(scope-config): fix scope config query #8248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XS
dosubot
bot
added
component/framework
|
Hi @klesh any updates for the review of the PR? |
klesh
previously approved these changes
Jan 8, 2025
|
I'm sorry for not getting back to you sooner. |
|
@klesh yes I tested it both with MySQL and PostgreSQL, I can provide some screenshots if you want (but most likely I will be able to do so next week). |
klesh
approved these changes
Jan 14, 2025
|
Thanks for your contribution. |
|
Hello @klesh will happily do so will ping you when ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
GetProjectsByScopeConfigfailing for Postgres due to_devlake_blueprint_scopesbeing a stringDoes this close any open issues?
Closes #8237